2 Commits

Include renames

Author	SHA1	Message	Date
Claude	8f0da2a806	feat(pubsub,channels)!: handles are addresses — bus, hub and session registries are supervised children ... smarm 0.7 (415effb, "lifetime is the actor's — refs are addresses") removed the rule these three actors were built on: a GenServerRef no longer owns the server, the loop holds its own inbox sender, and the inbox never closes when the last ref drops. urus's pubsub table, channel hub bus and session registries were still governed by that deleted rule — PubSub::new() spawned the table and the handle owned its life — so nothing commanded them to stop. What still terminated a run was the root-exit sweep, racing the drain: shutdown_with_open_chat_terminates and channels_wire::shutdown_with_open_channel_terminates failed 4 times in 25 --all-features runs with "serve did not return: ... outlived the drain: Timeout". Zero in 10 full-suite runs after this change. The fix is not a supervisor wrapped around the old shape. Every gotcha in this area descended from constructors that spawn: PubSub::new(), ChannelHub::new() and PrefixRouter::channel_session() all started actors, which forced in-runtime-only construction, which forced the Arc<OnceLock<..>> lazy-init from the first handler, which forced the "cell must not be static" and "a relay must never hold a PubSub clone" rules. Five documented rules propping up one inverted dependency. So: description is separated from instantiation. - PubSub<M> is a name, not a GenServerRef: const-constructible, Copy, spawns nothing, valid outside the runtime and in a static. Operations resolve through the registry per call, so a table restarted by its supervisor is reached transparently (one lookup per broadcast — bench before caching a ref, which would go stale across exactly the restart the supervisor exists to perform). PubSub::new() is gone; PubSub::new(name) + PubSub::child() replace it. - ChannelHub::new(bus, router) returns (hub, Vec<ChildSpec>) — the bus table plus one registry per session route. Returning both is the point: a hub whose children were never started compiles and fails on the first join, so the vec is not left behind a method you can forget to call. #[must_use]. - channel_session gains a registry name; each session registry is separately named and separately supervised. - serve_with/serve_with_shutdown take a Vec<ChildSpec> of app children and build the root as RestForOne[..app children, endpoint]. They start before the endpoint and, shutdown being ordered in reverse, stop after it has drained, so a request still in flight can reach the bus. RestForOne because a bus crash leaves live sockets addressing a table that no longer knows them. - Deleted: the Arc<OnceLock> idiom from both examples and both test pipelines, and the module rules that existed only to hand-manage a refcount. Known cost, not fixed here: channel_session("session:*", "chat-sessions", f) puts two unrelated string literals side by side and nothing catches a transposition — a RegistryName newtype is the obvious follow-up. Tests: 111 lib + 50 integration + 2 doc green, clippy clean, 10/10 full-suite runs. Unit tests poll for name binding before use — smarm's start-order-is-not- start-readiness gap; real apps don't hit it, since a handler only runs once a connection has been accepted.	2026-08-20 14:49:23 +00:00
Claude	0de2baa72d	feat(channels): opt-in session persistence — v0.6 chunk 3 ... ChannelSession<P> (src/channels/session.rs): a channel actor that outlives its transport, buffering outbound broadcasts as the same Arc<Broadcast<P>>s the relay path carries (zero re-allocation) until rejoin, buffer cap, or TTL. Registered per pattern via PrefixRouter::channel_session::<S>(pattern, factory) / channel_session_default::<C>(pattern); one registry gen_server per registration, monomorphic over S::Key (no type erasure). Machinery: deploy() computes the key on the conn actor and casts the join handshake to the registry; the registry maps key -> (pid, control sender), forwards reattaches, spawns-and-monitors fresh actors, and prunes on Down (pid-guarded against replaced entries). The session actor selects [inbound, bus, ctl] attached and select_timeout([ctl, bus], ttl-remaining) detached; detach triggers are the closed inbound arm and ws send failure (the failed broadcast is the buffer's first entry — nothing lost). Drain re-encodes under the new join generation. As-landed decisions (each in module docs): - ChannelFactory gained a #[doc(hidden)] deploy() seam (default = ephemeral linked actor, the chunk-1 behavior verbatim); JoinHandshake and ChannelInbox are opaque pub structs. Channel construction moved from run_channel into deploy — same linked blast radius. - Every attach calls ch.join() again (rejoin acks need a payload and channels get to re-auth); session channels must treat join as re-entrant. - A rejected rejoin ENDS the session (no zombie sessions held open for unauthorized clients); next join is a cold start. - A second transport EVICTS the first (best-effort phx_close); a session is single-transport. - Explicit leave ends the session, not just the attachment. - TTL per detach episode; subscribe once, on first successful join; cap.max(1) semantics (cap 0 = first buffered message tears down, but an empty buffer still waits out the TTL). - Key: Clone beyond the ratified Eq+Hash+Send — the registry keeps a pid -> key reverse index for Down pruning. - The registry spawns eagerly at registration (channel_session is in-runtime-only, same law as ChannelHub::new): a lazy OnceLock would block std-sync under green threads on first-join races. - Shutdown composes WITHOUT links: conns die -> router Arcs drop -> registry inbox closes -> registry exits -> ctl senders drop -> detached sessions wake on the closed ctl arm, terminate, exit. shutdown_with_detached_session_terminates is the proof (ttl 30s vs 5s budget — only the chain can reap it). Tests: 6 session unit tests (buffer-and-drain ordering across reconnect, TTL expiry, cap teardown, leave, eviction incl. stale conn-entry self-prune, rejected rejoin) + the shutdown integration test. Shared toy codec + conn harness extracted to channels/testkit.rs (mod.rs tests now import it; no behavior change). Hammer: 35x lifecycle subset (+channels +session) + 3x full (phoenix) + 1x full (phoenix+smarm-trace) + featureless + channels-only, all green; dbg-grep clean. Suite: 90 unit + 46 integration + 2 doc under --features phoenix.	2026-06-12 15:22:54 +00:00